feat: enforce secret requirement for session creation#1025
Merged
Conversation
bjohansebas
commented
Feb 13, 2025
| // backwards compatibility for signed cookies | ||
| // req.secret is passed from the cookie parser middleware | ||
| var secrets = secret || [req.secret]; | ||
| var secrets = secret; |
Member
Author
There was a problem hiding this comment.
I need to review this part because if I remove it, the tests still pass. It's likely that several tests need to be created if this is necessary.
Member
Author
There was a problem hiding this comment.
That is from the early days of Connect (senchalabs/connect#580). Initially, they used cookie-parser to secure cookies. Now, the package itself has the option to handle it on its own, so it is safe to remove it since this package is being decoupled from cookie-parser.
bjohansebas
marked this pull request as ready for review
February 13, 2025 04:39
raphendyr
reviewed
Mar 14, 2025
raphendyr
left a comment
raphendyr
left a comment
There was a problem hiding this comment.
I find the logic to bee correct. Some minor notions in comments.
raphendyr
reviewed
Mar 17, 2025
raphendyr
left a comment
raphendyr
left a comment
There was a problem hiding this comment.
I like it. Just needs a decisions about const and lint.
bjohansebas
commented
Mar 18, 2025
UlisesGascon
approved these changes
Mar 18, 2025
Phillip9587
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it is mandatory to have a secret to create the session, a deprecated feature has been removed.
Context:
That is from the early days of Connect (senchalabs/connect#580). Initially, they used cookie-parser to secure cookies. Now, the package itself has the option to handle it on its own, so it is safe to remove it since this package is being decoupled from cookie-parser